search

eclipse-ee4j / mojarra

Mojarra, a Jakarta Faces implementation
Other
158 stars 108 forks source link

ui:repeat clarification on attributes, such as offset and size #5289

Closed BalusC closed 8 months ago

BalusC commented 11 months ago

https://github.com/jakartaee/faces/issues/1713

cc @tandraschko

mnriem commented 9 months ago

LGTM. If it is targeted to only 5.0 is it maybe time to make UIRepeat go to the same package as the rest of the UI classes?

BalusC commented 9 months ago

If it is targeted to only 5.0 is it maybe time to make UIRepeat go to the same package as the rest of the UI classes?

jakarta.faces.component.UIRepeat? Sounds good to me. Should go via separate spec issue tho.

tandraschko commented 9 months ago

+1

pizzi80 commented 9 months ago

+1 for everything :smiley:

BalusC commented 9 months ago

Associated TCK https://github.com/jakartaee/faces/pull/1852

mnriem commented 8 months ago

@BalusC Is this waiting on a review? Looks like the jakarta-faces side was done?

BalusC commented 8 months ago

I actually waited for a working TCK. But yeah, I'll just merge.