5.0 Faces Standard Converters with Generics

eclipse-ee4j / mojarra

Mojarra, a Jakarta Faces implementation

Other

160 stars 109 forks source link

5.0 Faces Standard Converters with Generics #5306

Closed pizzi80 closed 2 months ago

pizzi80 commented 1 year ago

https://github.com/jakartaee/faces/issues/1822

Basic Converters with Generics
Basic Converters optimized

mnriem commented 11 months ago

@pizzi80 What is the status of this PR?

pizzi80 commented 11 months ago

The task was finalized on June 22 with the commit https://github.com/eclipse-ee4j/mojarra/pull/5306/commits/6590ff1cbd9c7da5101ce3a6868f1978f48e8a8e.

However, due to numerous merged pull requests in the interim, I had to synchronize my fork, make adjustments to some imports, and alter the name. (last commit)

This was necessitated by the decision of the Faces API community to defer the usage of Generics to Faces 5+

mnriem commented 11 months ago

@pizzi80 So this PR can be closed out?

pizzi80 commented 11 months ago

If the master is now the version 5.0, I think that it could finally be merged

mnriem commented 11 months ago

@BalusC @arjantijms What do you think?

pizzi80 commented 11 months ago

@BalusC Thanks for taking the time to review my code ....

I'll fix everything the next week

pizzi80 commented 11 months ago

During this work I've found that inside the generic NumberConverter

there are some ugly hacks for Java 1.4 and Java 7 that use reflection to invoke some methods that are obviously implemented in Java 8+ ...

Jsf 2.3 is Java 8+, right?

Can I remove the hacks on a separate PR?

BalusC commented 2 months ago

API has been split from Mojarra project into Faces project. Current PR is superseded by https://github.com/jakartaee/faces/pull/1942