Use CDI as injection provider and fixed InitFacesContext

eclipse-ee4j / mojarra

Mojarra, a Jakarta Faces implementation

Other

160 stars 109 forks source link

Use CDI as injection provider and fixed InitFacesContext #5354

Closed BalusC closed 10 months ago

BalusC commented 10 months ago

https://github.com/eclipse-ee4j/mojarra/issues/4480

Since API split there were a couple "RESOLVE THIS" comments especially wrt InjectionProvider and InitFacesContext. The InjectionProvider has become CDI and the overcomplicated Thread-InitFacesContext mapping has been removed/simplified.

BalusC commented 10 months ago

We should probably also get rid of Util#getCDIBeanManager() in Mojarra and just use CDI.current().getBeanManager() all over place. CDI has currently sufficiently matured that this always works, even in Tomcat. WDYT?

BalusC commented 10 months ago

Ok let's merge now, so master branch at least produces a working Mojarra impl.