search

eclipse-ee4j / mojarra

Mojarra, a Jakarta Faces implementation
Other
158 stars 107 forks source link

Fixes #5357 - Move jakarta.faces-api Maven module to API project #5358

Closed mnriem closed 7 months ago

mnriem commented 7 months ago

Depends on https://github.com/jakartaee/faces/issues/1856 and the SNAPSHOTs now being published to OSS Sonatype SNAPSHOT repository

BalusC commented 7 months ago

LGTM but how do I re-run the build at all?

Also not seeing the 5.0.0-SNAPSHOT here yet even when it was merged into Faces project 4d ago https://jakarta.oss.sonatype.org/content/repositories/staging/jakarta/faces/jakarta.faces-api/

mnriem commented 7 months ago

@arjantijms Do you know if Eclipse Jenkins publishes to OSS Sonatype automatically?

mnriem commented 7 months ago

@BalusC Maybe for the time being I should add the API project as a git submodule so it is available during the build?

mnriem commented 7 months ago

@BalusC Added the Faces API as a git submodule so this now all builds fine. Let me know if you are OK with merging it like this? Thanks!

BalusC commented 7 months ago

Merged. But we should look at the snapshot thing. I remember having asked to @arjantijms if we could enable nightly builds. And I also remember that it had to be configured somewhere in Jenkins CI. Also that GlassFish project has a working setup which we could perhaps borrow.