search

eclipse-ee4j / mojarra

Mojarra, a Jakarta Faces implementation
Other
158 stars 107 forks source link

Make sure that ViewHandler#getViews() also returns programmatic facelets #5364

Closed BalusC closed 7 months ago

BalusC commented 7 months ago

https://github.com/eclipse-ee4j/mojarra/issues/5362

I only question the validity to add the missing @Nonbinding to the @View annotation value at this stage already, which was clearly an oversight. I checked spec and apidocs, this is nowhere explicitly mentioned for all other existing Faces annotations with a @Nonbinding field. So I felt it's kind of safe to fix it in Mojarra 4.0.6 already instead of in Faces 4.1 (which is not yet released!).

If you disagree, let me know then I'll adjust the approach to fetch all CDI beans and then manually filter them instead of fetching them by qualifier, though this might be less efficient. And in the meanwhile try to get that @Nonbinding into Faces 4.1 before it gets released.

cc: @tandraschko

tandraschko commented 7 months ago

+1

mnriem commented 7 months ago

Unless there is major broken functionality I would take the side of caution and do it for 4.1.

BalusC commented 7 months ago

I would take the side of caution and do it for 4.1.

Okay. I already guessed.

BalusC commented 7 months ago

@manfredriem okay, https://github.com/eclipse-ee4j/mojarra/pull/5368

Current PR has been superseded by https://github.com/eclipse-ee4j/mojarra/pull/5369