search

eclipse-ee4j / mojarra

Mojarra, a Jakarta Faces implementation
Other
158 stars 107 forks source link

@jakarta.faces.annotation.View#value must be @Nonbinding #5368

Closed BalusC closed 7 months ago

BalusC commented 7 months ago

https://github.com/jakartaee/faces/issues/1865 https://github.com/eclipse-ee4j/mojarra/issues/5367

volosied commented 7 months ago

This causes some regressions in 5.0 / 4.1:

WELD-001318: Cannot resolve an ambiguous dependency between: - Managed Bean [class com.example.HelloFacelet2] with qualifiers [@Any @View], - Managed Bean [class com.example.HelloFacelet] with qualifiers [@Any @View]

I applied a similar change to MyFaces and found the same problem. I think View.Literal.of(someURI) during the bean lookup doesn't work now because the annotation is not considered anymore?

BalusC commented 7 months ago

Right. There's the why. I'll have to revert this for now.

BalusC commented 7 months ago

Reverted: https://github.com/eclipse-ee4j/mojarra/commit/12ca56e2838dece42dfef3bfaa50914a1355ce24