[MOJARRA_5375] The jfwid contains the session ID

eclipse-ee4j / mojarra

Mojarra, a Jakarta Faces implementation

Other

158 stars 107 forks source link

[MOJARRA_5375] The jfwid contains the session ID #5376

Closed jasondlee closed 6 months ago

jasondlee commented 6 months ago

Issue: https://github.com/eclipse-ee4j/mojarra/issues/5375

Changes:

Modify ClientWindowImpl to generate window ID w/o using session id
Add TokenGenerator from MyFaces

jasondlee commented 6 months ago

Please make sure this can also be applied to 5.0 branch

I don't see any reason why this wouldn't apply cleanly to any 4.x or 5.x branch. Am I missing something?

BalusC commented 4 months ago

These changes don't seem to be present in 4.0?

Please keep in mind that master branch is the future 5.0 version and that the currently active version for bugfixes/enhancements is 4.0. It's therefore much easier to just target the fix at 4.0, it can then be safely merged into 4.1 and then 5.0. It is not possible to merge backwards to an older version as that would corrupt the version history. You'd need to do it by hand instead (cherrypick, backport, ctrl+c/v, etc).