eclipse-ee4j / mojarra

Mojarra, a Jakarta Faces implementation

Other

158 stars 107 forks source link

NPE in ExternalContextImpl.encodeRedirectURL when no ViewRoot availab… #5384

Closed shadogray closed 5 months ago

shadogray commented 5 months ago

5383

FacesContextImpl: encodeRedirectURL accesses FacesContext.ViewRoot.attributes w/o checking, if ViewRoot has been set already This causes NullPointerException and so failure of the request

tandraschko commented 5 months ago

@arjantijms @BalusC @manfredriem could you please merge this ASAP? i would like to not workaround this in DeltaSpike - and you might releasier earlier (fingers crossed)

BalusC commented 5 months ago

Merged but please note that this PR is on master branch not on 4.0 branch. You'll need to create a separate PR for 4.0 branch.

tandraschko commented 5 months ago

Can you merge to 4.0 pls?

BalusC commented 5 months ago

You can't merge backwards in versions. In order to maintain a consistent revision history, you can only merge upwards in versions (e.g. first PR for 2.3 then simply merge into 3.0 then 4.0 then 4.1 then master (5.0)).

But leave it, I made another PR for 4.0 whereby I reviewed and cleaned up all this logic: https://github.com/eclipse-ee4j/mojarra/pull/5385, see also the main ticket.