search

eclipse-ee4j / mojarra

Mojarra, a Jakarta Faces implementation
Other
158 stars 107 forks source link

PartialViewContextImpl should use same VisitContext to reset values as the one used to process the execute and render #5397

Closed BalusC closed 4 months ago

BalusC commented 4 months ago

https://github.com/eclipse-ee4j/mojarra/issues/5396

BalusC commented 4 months ago

cc: @tandraschko

tandraschko commented 4 months ago

+1 but do we really need EXECUTE_LIFECYCLE? AFAICS its not used in our IMPLs but the MF javadoc says something like

     * Hint that indicates that the visit is being performed as part of
     * lifecycle phase execution and as such phase-specific actions
     * (initialization) may be taken.

if i reset something, i dont want to trigger "initialization" of something

tandraschko commented 4 months ago

currently it's only used for partial processing the tree, i dont think we should use it for resetting components

BalusC commented 4 months ago

Fair point, adjusted.

tandraschko commented 4 months ago

nice!

@BalusC Do you have already plans to merge this and release 4.0.6? I would like to have a release, so we can further work on DeltaSpike integration tests as they currently failing because of the other PR encoding/encodeRedirectUrl thing which is already fixed and merged