#5417: remove "optimization" when composite attribute default is literal instead of VE, this will fail when the final value itself is VE

eclipse-ee4j / mojarra

Mojarra, a Jakarta Faces implementation

Other

158 stars 107 forks source link

#5417: remove "optimization" when composite attribute default is literal instead of VE, this will fail when the final value itself is VE #5418

Closed BalusC closed 3 months ago

BalusC commented 3 months ago

https://github.com/eclipse-ee4j/mojarra/issues/5417

~Hold on with proactively merging. I want to run TCK before merge just to ensure there are no corner cases which depend on this "optimization".~ TCK passed.

(sorry for imports being shuffled in the code diff, I reconfigured Eclipse to treat jakarta. the same way as javax.)

BalusC commented 3 months ago

Is there a performance penalty?

Theoretically not. We would otherwise have retrieved issue reports from people complaining that default="#{foo}" is significantly slower than default="foo".

Does it break backwards compatibility?

That's exactly why I wanted to run TCK on this. It has passed all tests on this branch.