search

eclipse-ee4j / mojarra

Mojarra, a Jakarta Faces implementation
Other
163 stars 111 forks source link

Endless loop in MultiViewHandler.normalizeRequestURI #5525

Open pdudits opened 1 week ago

pdudits commented 1 week ago

Describe the bug

When FacesServlet is mapped to /* or invoked via forwarding where other servlet has this mapping, the view processing never terminates as it is stuck in while loop in MultiViewHandler.normalizeRequestURI. mapping is "" in this case and therefore loop condition is always true and the viewId never changes.

To Reproduce

Steps to reproduce the behavior:

  1. Set mapping of facesServlet to /*
  2. Make a request to a view
  3. Observe infinite loop

Expected behavior

Request processing should terminate. Given that /* is rare but valid entry, it shouldn't try any normalization

Additional context

Will provide PR for version 4, master is not buildable at this time.

BalusC commented 2 days ago

Will provide PR for version 4

Your PR was for master not 4.0 so I closed it. Please recreate PR for 4.0.

master is not buildable at this time

Can you please be a bit more specific so we can fix this.