eclipse-ee4j / openmq

OpenMQ
https://projects.eclipse.org/projects/ee4j.openmq/
Other
49 stars 34 forks source link

CacheSweeper Thread can never exit from run #353

Closed glassfishrobot closed 4 years ago

glassfishrobot commented 10 years ago

Not 100 percent sure I'm at the correct place for this report and who is writing on the UMSServlet stuff. If this is the wrong place, please guide me in the right direction.

I'm using the open-mq5.0 library from https://mq.java.net/, other versions might be affected too.

This especially striked me when manually starting a UMSServlet connected to an embedded broker on Tomcat and trying to cleanly destroy() it:

com.sun.messaging.ums.service.CacheSweeper can never exit correctly due to assignment which will always be true in line 169 in run() method:

**com.sun.messaging.ums.service.CacheSweeper.java** public void run() {
   while (isRunning = true) {
      // do some work....
   }
 }
}

A not so important thing that occurred to me when looking at the class: there's a typo in the thread's name (line 68), don't think it's worth to open an own bug for this. "CacheSweper" probably should be "CacheSweeper".

**com.sun.messaging.ums.service.CacheSweeper.java** private static final String myName = "CacheSweper";

Thanks,

Environment

Tomcat 7.0.42 OpenMQ 5.0

glassfishrobot commented 6 years ago
glassfishrobot commented 10 years ago

@glassfishrobot Commented Reported by thembones410

glassfishrobot commented 7 years ago

@glassfishrobot Commented This issue was imported from java.net JIRA MQ-353