search

eclipse-ee4j / parsson

Parsson Project
Other
10 stars 21 forks source link

[#112]Corrected skip methods behavior of JsonParserImpl; #113

Closed api-from-the-ion closed 8 months ago

api-from-the-ion commented 11 months ago

Corrected the behavior of the skip methods in the parser implementation

api-from-the-ion commented 11 months ago

I'm writing the tests here, and I'm missing Junit 5 dearly. My question: could we move to Junit 5? This should be just a simple work of changing dependencies and modifying the 380 tests to use annotations and so on.

lukasj commented 11 months ago

My question: could we move to Junit 5? This should be just a simple work of changing dependencies and modifying the 380 tests to use annotations and so on.

If someone provides PR for this, I see no reason to not to move there.

api-from-the-ion commented 11 months ago

  • avoid whitespace changes - use spaces and not tabs

    • avoid static imports - they just make reviewers life more difficult when mixed with other changes

    • are pom updates required here? they are usually handled through separate PRs (or through PRs which are to be just rebased instead of being squashed)

P.S.: Created a branch with Checkstyle. It has immediately 468 errors. Could anybody take a look on the rules, if they are OK? If so, I would correct the errors and make a PR of corrections and Checkstyle.

api-from-the-ion commented 11 months ago

If someone provides PR for this, I see no reason to not to move there.

OK, so we don't need some ticket for this? Just the PR full of commits to review? And another question: should I create a branch from the current master or is it OK, to fork some of the branches?

I see, I explained myself not so clearly. I have two (independent) changes in my mind. First: to update a JUnit. And independently, move from "inherit from TestCase" schema to the "use annotations" schema on tests. Anybody has some objections on the second case?