search

eclipse-ee4j / soteria

Soteria, a Jakarta Security implementation
Other
57 stars 29 forks source link

Extract OIDC implementation into its own artifact #320

Open kalgon opened 2 years ago

kalgon commented 2 years ago

As far as I can see, the OIDC package is pretty well isolated and does not depend on other internal Soteria classes (except for org.glassfish.soteria.Utils). Wouldn't it be possible to extract this module into its own artifact so that it can be embedded directly into the application? I'm using the version of Soteria that comes with my application server (JBoss EAP) and I don't know when it will be updated with a version of Soteria that contains OIDC.

arjantijms commented 2 years ago

For that purpose, this one is probably beter suited:

https://github.com/payara/ecosystem-security-connectors

kalgon commented 2 years ago

Well, I tried to use the payara openid-standalone on JBoss EAP but it fails (probably) because of this line. I am redirected in a loop to /org.jboss.resteasy.specimpl.ResteasyUriBuilder@XXX. The authUrl should be built using UriBuilder.build() instead of toString().

kalgon commented 2 years ago

I made a PR for payara but the same problem seems to be present in soteria as well.

arjantijms commented 2 years ago

Thanks @kalgon! I'll take a look at this very soon.