eclipse-ee4j / starter

Eclipse Starter for Jakarta EE
Eclipse Public License 2.0
50 stars 40 forks source link

UI for #153 - Add support for Zip download in UI #156

Closed OndroMih closed 1 year ago

OndroMih commented 1 year ago

This is a simple UI that adds a button to download a ZIP file based on the data in the form.

DO NOT MERGE yet - this requires a running server with this servlet: https://github.com/eclipse-ee4j/starter/pull/155

Currently, the button points to a local server running the servlet (http://localhost:8080/starter-ui/download.zip). When the server is deployed on a production URL, we'll need to change the URL in the path constant in the download() function.

To preview how it works:

eclipse-starter-bot commented 1 year ago

Can one of the admins verify this patch?

IvoNet commented 1 year ago

I guess the servlet actually runs under http://localhost:8080/jakarta-starter-ui/download.zip? Because the artifactId is jakarta-starter-ui and that translates to the context root right?!

m-reza-rahman commented 1 year ago

Kindly do coordinate with @rokon12. I believe he is working to get this hosted. It’s best to try to avoid duplication of effort given the few folks we have. He may have changes in flight already.

OndroMih commented 1 year ago

I guess the servlet actually runs under http://localhost:8080/jakarta-starter-ui/download.zip?

@IvoNet , this really depends on how you deploy the app locally. I'm running it on GlassFish from Netbeans, and, by default, Netbeans infers the context root from the project directory, which is starter-ui. But it's not important. This URL will need to be adapted once the production service is up and running.

m-reza-rahman commented 1 year ago

Closing this. It is already addressed.