search

eclipse-ee4j / starter

Eclipse Starter for Jakarta EE
Eclipse Public License 2.0
50 stars 38 forks source link

Add server-side validation #187

Closed m-reza-rahman closed 1 year ago

eclipse-starter-bot commented 1 year ago

Can one of the admins verify this patch?

m-reza-rahman commented 1 year ago

This is not ready to merge yet, but a review and testing would be very useful, @jeyvison.

m-reza-rahman commented 1 year ago

I think I have done what I can for now. Other people should really review, test and perhaps suggest improvements. It may also be that this is good enough to merge and do a 2.0 release. Any bugs/enhancements could always be handled later.

OndroMih commented 1 year ago

Hi, @m-reza-rahman , is there a valid reason why GlassFish isn't enabled for Core profile? I know that GlassFish hasn't certified with Core Profile, but it is certified as Web and Full profile. The Core profile is a subset of Web, so there's no reason why Core Profile apps couldn't run on Web Profile runtimes. Do we really need to strictly require that options for the Core profile are certified with Core Profile?

m-reza-rahman commented 1 year ago

Since this is an official starter, I think the right thing to do is go by certifications. Otherwise, certifying against a particular profile becomes a meaningless concept.