search

eclipse-ee4j / starter

Eclipse Starter for Jakarta EE
Eclipse Public License 2.0
50 stars 38 forks source link

Apply Artifact ID to all output #189

Closed angayap closed 3 months ago

angayap commented 1 year ago

Hello, can we point to in file archetype\src\main\resources\archetype-resources\pom.xml line 53 <name>${artifactId}</name>

line 1153 <finalName>${artifactId}</finalName>

Tank

m-reza-rahman commented 1 year ago

Do you feel this is a high priority? If so, please issue a PR including fixes to the Dockerfile and all documentation. If not, we can get to this when we are able. It's not particularly difficult, but it is a lot of work and I am not sure it's that big a deal.

ojuschugh1 commented 1 year ago

sir we have to only change name and filename in all pom.xml file in src ?

m-reza-rahman commented 1 year ago

As I already mentioned, it's far more than that. The generated Dockerfile and all associated documentation, including generated READMEs will need to be handled. If someone wants to work on this I suggest first adequately understanding the project. Most likely that will take days if not weeks for a newcomer. This is no easy task.

ojuschugh1 commented 1 year ago

ohh that's why i was thinking it seems so easy i just right now commited it lol :(

geziefer commented 9 months ago

I could do this one together with #274

geziefer commented 8 months ago

Was addressed in PR #291 All files now respect the given artifactId, including pom, readme, docker, war Java package is left unchanged for now, it contains groupId + fix sub package (-> see mailing list discussion, may be changed in different PR)

m-reza-rahman commented 3 months ago

Fixed.