search

eclipse-ee4j / starter

Eclipse Starter for Jakarta EE
Eclipse Public License 2.0
50 stars 38 forks source link

Add header and footer on the UI #205

Closed rokon12 closed 1 year ago

rokon12 commented 1 year ago

This pull request aims to enhance the user interface of the project by adding a header and footer to the UI. Currently, the UI elements are simply copied from https://start.jakarta.ee/, and there is ample room for improvement.

image
eclipse-starter-bot commented 1 year ago

Can one of the admins verify this patch?

m-reza-rahman commented 1 year ago

Looks fine. Merging.

geziefer commented 1 year ago

@m-reza-rahman / @rokon12 The font is now very small, I can hardly read the explanation text on my small-screen laptop - was that intended? It was larger before doing the templating.

This is 100% zoom in Chrome: image

m-reza-rahman commented 1 year ago

Please work with @rokon12 to get it addressed. Also, @scottkurz probably should review the text, etc.

geziefer commented 1 year ago

Just to make sure to be clear on that: The small font has nothing to do with my changes, it was introduced by this PR containing the templating and thus I assume a different style sheet.