search

eclipse-ee4j / starter

Eclipse Starter for Jakarta EE
Eclipse Public License 2.0
50 stars 38 forks source link

Do we want to include .gitignore? .dockerignore? in archetype #214

Closed scottkurz closed 1 year ago

scottkurz commented 1 year ago

Not sure how much discussion has been had on this already. I tried to search the ML quick and didn't see much, sorry if I missed it.

Some ideas for .gitignore:

  1. Grab the generic Maven one: https://github.com/github/gitignore/blob/main/Maven.gitignore
  2. Do a real simple one: 
    target/
.mvn/wrapper/maven-wrapper.jar
  3. Or I guess the status quo: do nothing and leave it to the user to think about when they git init.

I guess I'd vote for 2. The 1. has maybe a bit of an Eclipse IDE bias?

Thoughts?

.dockerignore

I mention it for completeness but not sure it's worth it. It could end up runtime specific. It could be added later if someone really thought it'd be useful.

m-reza-rahman commented 1 year ago

Please issue a PR on whichever you think is best. All options are fine, #2 looks good enough for now. I doubt folks would have strong opinions either way.