search

eclipse-ee4j / starter

Eclipse Starter for Jakarta EE
Eclipse Public License 2.0
50 stars 39 forks source link

Update nightly.yml #230

Closed ojuschugh1 closed 1 year ago

ojuschugh1 commented 1 year ago

Test the running generated project via Maven (e.g. call the REST endpoint) Test the running generated project via Docker

eclipse-starter-bot commented 1 year ago

Can one of the admins verify this patch?

m-reza-rahman commented 1 year ago

Is this a draft PR that you are still working on? If so, please mark it as such. Otherwise, please open PRs that are complete, self-sufficient and add a specific value to the project. The PR in it's current form does not do that.

ojuschugh1 commented 1 year ago

i have added code to test -: Test the running generated project via Maven (e.g. call the REST endpoint) Test the running generated project via Docker as addressed here More robust nightly build #185.

m-reza-rahman commented 1 year ago

This is basically redundant code that does not actually do much. Please take the time to understand the project and how you may add meaningful tests. This is not a trivial task. It requires serious research and weeks or months of work.

ojuschugh1 commented 1 year ago

ok got it sir,Sorry for disturbing your time :(