search

eclipse-ee4j / starter

Eclipse Starter for Jakarta EE
Eclipse Public License 2.0
50 stars 39 forks source link

#248 Improve look and feel of UI #249

Closed kito99 closed 1 year ago

kito99 commented 1 year ago

Addresses #248.

eclipse-starter-bot commented 1 year ago

Can one of the admins verify this patch?

kito99 commented 1 year ago

I'm getting this error for the ECA:

image

Not quite sure what the deal is...kito-public@virtua.tech is a valid email, but it's not the one I'm using for either my Github or Eclipse accounts.

jeyvison commented 1 year ago

Hi, @kito99 :) Can you please amend your commits with the email you used to sign the ECA, please?

m-reza-rahman commented 1 year ago

Hi @ivargrimstad, could you possibly help debug? I honestly have no idea.

scottkurz commented 1 year ago

Is there an easy way to shrink the size of the banner at the top? It still looks just as big to me in building and running locally.

I don't mean to criticize this PR if this was not something you were trying to accomplish here. However, that to me seemed to be the biggest "look and feel" issue, and so, if there's something easy we could do to shrink this further, maybe we could still try that? Sorry, not too familiar with the UI elements myself.

m-reza-rahman commented 1 year ago

Hi @ivargrimstad, could you please comment on the above? I agree with Scott. That said, I understand we need to conform to the look and feel of the jakarta.ee site.

kito99 commented 1 year ago

@scottkurz the banner will be addressed in #246. It's out of scope for this issue (#248).

m-reza-rahman commented 1 year ago

Hi @kito99, I think you will need to switch the email for the PR to the one that matches your Eclipse Foundation account.

kito99 commented 1 year ago

Replaced by #252.