Closed kito99 closed 1 year ago
Can one of the admins verify this patch?
I'm getting this error for the ECA:
Not quite sure what the deal is...kito-public@virtua.tech is a valid email, but it's not the one I'm using for either my Github or Eclipse accounts.
Hi, @kito99 :) Can you please amend your commits with the email you used to sign the ECA, please?
Hi @ivargrimstad, could you possibly help debug? I honestly have no idea.
Is there an easy way to shrink the size of the banner at the top? It still looks just as big to me in building and running locally.
I don't mean to criticize this PR if this was not something you were trying to accomplish here. However, that to me seemed to be the biggest "look and feel" issue, and so, if there's something easy we could do to shrink this further, maybe we could still try that? Sorry, not too familiar with the UI elements myself.
Hi @ivargrimstad, could you please comment on the above? I agree with Scott. That said, I understand we need to conform to the look and feel of the jakarta.ee site.
@scottkurz the banner will be addressed in #246. It's out of scope for this issue (#248).
Hi @kito99, I think you will need to switch the email for the PR to the one that matches your Eclipse Foundation account.
Replaced by #252.
Addresses #248.