Closed geziefer closed 1 year ago
Can one of the admins verify this patch?
For some reason, a wrong email address slipped in - the one labled as not being covered by leagal agreement (alexander.ruehl.sti@valantic.com) is wrong, correct is alexander.ruehl@sti.valantic.com, which is covered) - does this has to be fixed to continue? If so, what do I have to do to fix that? (Locally it's correct now, so for the future I'm set ;-)
hi @geziefer , you can try to rebase you commits ammending the author in each one of them.
@jeyvison Do I have to do it for continuing with the PR? I wonder, why this was not a problem in previous commits, since this seemed to be wrong in my git config from the beginning of my participation.
@geziefer You do, since we cant get contribuitions without a valid ECA. Have you checked if (alexander.ruehl.sti@valantic.com) had an ECA attached to it and for some reason it expired? Maybe thats the case.
@jeyvison Ok, I'll try the rebase/ammend and file new PR. No it did not expire, it was just a typo in my git config email I didn't notice yet.
Feature implemented as described in #274
Tests done: