search

eclipse-ee4j / starter

Eclipse Starter for Jakarta EE
Eclipse Public License 2.0
50 stars 39 forks source link

Fix #246: Header must be fetched from jakarta.ee #293

Open yashTEF opened 8 months ago

yashTEF commented 8 months ago

PR for #246

This PR addresses changes required for fetching the header/footer html fragments from: https://jakarta.ee.

eclipse-starter-bot commented 8 months ago

Can one of the admins verify this patch?

yashTEF commented 8 months ago

While the changes do the job of fetching the header and footer fragments, there are still some menu links which have relative path as source which will need to be converted to absolute(refer: #246 (comment)) for this PR to be successfully merged.

@autumnfound, I can submit a patch to https://github.com/jakartaee/jakarta.ee for the changes required in the templates for you to review?

autumnfound commented 8 months ago

@autumnfound, I can submit a patch to https://github.com/jakartaee/jakarta.ee for the changes required in the templates for you to review?

If you feel comfortable submitting a patch, absolutely! Otherwise, you can create an issue and we can triage and take care of it in the near future as well.

yashTEF commented 4 months ago

@kito99, this PR is functional and maybe reviewed now.

@m-reza-rahman while this PR addresses the issue of fetching the headers/footers, I am not sure how the layout and styling for the UI are supposed to work as the existing starter UI available at: https://start.jakarta.ee is quite different to the above proposed.