search

eclipse-ee4j / starter

Eclipse Starter for Jakarta EE
Eclipse Public License 2.0
49 stars 40 forks source link

Add all positive cases for GlassFish runtime #304

Closed adan-jawad closed 6 days ago

eclipse-starter-bot commented 3 weeks ago

Can one of the admins verify this patch?

adan-jawad commented 3 weeks ago

Hello, I have added descriptions for docker support and organized the cases in the way specified. I have restored the old cases from the original file and have added my cases between the start and end comments for every java version for easy readability. I'll remove these comments once you review this.

m-reza-rahman commented 2 weeks ago

Please resolve conflicts with latest commits to master.

adan-jawad commented 2 weeks ago

I am a bit confused. Do I delete the cases where docker is not supported, or do I just remove that from the description?

m-reza-rahman commented 2 weeks ago

For now, kindly remove the cases where Docker is not supported and set them aside. These need to be added later as explicitly tested negative cases.

m-reza-rahman commented 2 weeks ago

Please resolve all merge conflicts.

m-reza-rahman commented 2 weeks ago

I will review if I have some time during the work week. Otherwise, may need to wait until the weekend.

adan-jawad commented 2 weeks ago

I will review if I have some time during the work week. Otherwise, may need to wait until the weekend.

Sure.

adan-jawad commented 6 days ago

Hello Reza, I am going to create a new pull request and I'm closing this one