eclipse-ee4j / starter

Eclipse Starter for Jakarta EE
Eclipse Public License 2.0
49 stars 40 forks source link

Add all positive cases for Open Liberty in nightly build #305

Closed mohamed-elzeni closed 2 weeks ago

eclipse-starter-bot commented 3 weeks ago

Can one of the admins verify this patch?

m-reza-rahman commented 3 weeks ago

I take it this is not ready for review again yet?

mohamed-elzeni commented 3 weeks ago

Not yet, it needs still needs more work.

m-reza-rahman commented 3 weeks ago

OK. Please take it out of draft mode when you think it is ready to merge or ask me explicitly to do an intermediate review of the draft.

mohamed-elzeni commented 3 weeks ago

I have added descriptions for Docker support and restored unnecessarily deleted cases. Can you please review?

mohamed-elzeni commented 3 weeks ago

The existing cases using full profile omit full profile from the name. Should I follow this convention?

m-reza-rahman commented 3 weeks ago

Up to you. Either way is fine as long as it is consistent across the board.

mohamed-elzeni commented 2 weeks ago

All conflicts have been resolved. I believe this is ready for review now.

m-reza-rahman commented 2 weeks ago

Well done! Merging.