search

eclipse-ee4j / starter

Eclipse Starter for Jakarta EE
Eclipse Public License 2.0
50 stars 39 forks source link

Check Dockerfile build for None and WIldFly runtimes #308

Closed Tasnim1147 closed 3 months ago

eclipse-starter-bot commented 3 months ago

Can one of the admins verify this patch?

Tasnim1147 commented 3 months ago

I have added a shell script check to verify whether a Dockerfile is generated after the archetype run. I am concerned that this might make the code heavy when accounting for all possible combinations. Please let me know if any improvements are needed.

Tasnim1147 commented 3 months ago

Yes, I was trying to test that the Dockerfile is generated where it is supposed to be and ensure that it isn't generated where it shouldn't be.

m-reza-rahman commented 3 months ago

OK. Let's not worry about the latter case. For the former, let's attempt an actual Docker build as a more robust test.

m-reza-rahman commented 3 months ago

The approach you took is good for the negative cases where a Dockerfile was not generated because the user input incorrectly asked for one.

Tasnim1147 commented 3 months ago

Removed the unnecessary checks and added docker build for generated Dockerfiles.