search

eclipse-ee4j / starter

Eclipse Starter for Jakarta EE
Eclipse Public License 2.0
50 stars 38 forks source link

Update header layout #329

Closed geziefer closed 2 weeks ago

geziefer commented 2 weeks ago

In the new version 2.0.6, the menu is in the image. image

m-reza-rahman commented 2 weeks ago

I have no idea what to make of this or what action to take. Is this a bug? An enhancement request? What is the actual change requested or issue to be fixed? Is this something existing or the result of a recent change?

Also, are you aware the Eclipse Foundation determines the layout of the header and footer? Indeed, both are in the process of being fetched dynamically soon: https://github.com/eclipse-ee4j/starter/pull/293.

geziefer commented 2 weeks ago

Well, the menu items are practically unreadable, that is definitely an issue. We could either have the menu above the banner, as it is on the main page jakarta.ee, or we could have a different CSS for it to make it readable on top of the banner.

geziefer commented 2 weeks ago

In case #293 addresses this and makes the menu readable again, this ticket could be closed.

m-reza-rahman commented 2 weeks ago

I am closing this as essentially a duplicate/out of scope to keep the issues clutter free. As I mentioned, this is not up to us. This is what the header layout was when we initially pulled it. Let's see what pulling the current headers does. If you have further feedback after that, you should provide it to the Eclipse Foundation, probably via @shabnammayel. We need to conform to whatever the Eclipse Foundation layout is.