eclipse-ee4j / tyrus

Tyrus
Other
113 stars 36 forks source link

Passing info from ServerEndpointCondig#Configurator to Endpoint instance #573

Open glassfishrobot opened 9 years ago

glassfishrobot commented 9 years ago

Spec issue - WEBSOCKET_SPEC-235

I believe we should try to make that work at in Tyrus; some ideas:

glassfishrobot commented 6 years ago
glassfishrobot commented 9 years ago

@glassfishrobot Commented Reported by @pavelbucek

glassfishrobot commented 9 years ago

@glassfishrobot Commented @pavelbucek said: there is no good solution for that issue, if we limit the change only to WebSocket API implementation; all we can do here is to introduce another ServerEndpointConfig#Configurator descendant (let's call it TyrusServerConfigurator), which would somehow provide access to any object (most likely userProperties).

Since we are extending original Configurator, we cannot change the method signatures. Also the Configurator is currently singleton, so we cannot easily set the value and let the code get it - the concurrent invocation won't be handled correctly. I see two possible approaches:

Currently I don't particularly like either of those, so if anyone has better suggestion, I'm all ears.. Thanks!

glassfishrobot commented 9 years ago

@glassfishrobot Commented Issue-Links: is related to WEBSOCKET_SPEC-235

glassfishrobot commented 7 years ago

@glassfishrobot Commented This issue was imported from java.net JIRA TYRUS-396