search

eclipse-ee4j / tyrus

Tyrus
Other
115 stars 37 forks source link

Support ClientEndpointConfig#getSSLContext #767

Closed jansupol closed 2 years ago

jansupol commented 2 years ago

Signed-off-by: jansupol jan.supol@oracle.com

NilsRenaud commented 2 years ago

I'm facing an issue with this change, is there any reason you removed these lines ?

(containers/grizzly-client/src/main/java/org/glassfish/tyrus/container/grizzly/client/GrizzlyClientSocket.java#758-761)

if (configuratorObject instanceof SslEngineConfigurator) {
    return new ExtendedSSLEngineConfigurator((SslEngineConfigurator) configuratorObject, uri.getHost());
}

@jansupol

jansupol commented 2 years ago

@NilsRenaud As you can see the lines were duplicated and now Tyrus 2.1.0 contains just a single copy of that condition.

The change is only in EE10 branch. If you are using the EE10 branch, could your issue be caused by missing EE10 dependencies? Tyrus 1.19 (EE8), 2.0.4 (EE9) still contain the condition duplicated.

NilsRenaud commented 2 years ago

Nop that's not duplicated line, the first line is org.glassfish.tyrus.client.SslEngineConfigurator and the second one is org.glassfish.grizzly.ssl.SSLEngineConfigurator

The second one allowed us to disable TLS hostname verification.

jansupol commented 2 years ago

oops, you are right. That needs to be fixed.

NilsRenaud commented 2 years ago

I've created an issue to track the fix : https://github.com/eclipse-ee4j/tyrus/issues/804 :)

jansupol commented 1 year ago

@jansupol 2.1.2 containing the fix is public now.

NilsRenaud commented 1 year ago

Thanks a lot @jansupol !