Closed mnriem closed 10 months ago
@jansupol I missed that. Note that the module-info then needs to be updated for Grizzly 4.0.1 as Grizzly now has different module names.
@mnriem Good to know, thank you!
@mnriem Grizzly has the module-info dodgy.
in grizzly-http-server
, the pom says:
<dependency>
<groupId>org.glassfish.gmbal</groupId>
<artifactId>gmbal</artifactId>
<scope>provided</scope>
<optional>true</optional>
</dependency>
but the module-info has a hard dependency on half of the glassfish:
requires gmbal;
requires org.glassfish.external.management.api;
requires pfl.basic;
requires pfl.tf;
requires org.objectweb.asm;
requires pfl.dynamic;
requires org.objectweb.asm.util;
requires org.objectweb.asm.tree;
requires org.objectweb.asm.tree.analysis;
requires pfl.basic.tools;
requires pfl.tf.tools;
requires org.objectweb.asm.commons;
The requirements should be static.
@arjantijms What do you think?
@jansupol I have changed the module-info for Grizzly. Can you see if it works now?
@mnriem @arjantijms Yes, the changes in Grizzly master are exactly what Tyrus would need. Thanks!
@jansupol The 4.0.2 Grizzly release is out the door!
@mnriem Thank you!!! Do you know what Glassfish will consume this Grizzly with JPMS, will it be Glassfish 8, or 7 as well?
The thing is what Tyrus needs to consume the new Grizzly, whether EE11 Tyrus, or EE10 Tyrus, too.
For EE11: #876
@jansupol It was integrated into Glassfish 7.0.12, see https://github.com/eclipse-ee4j/glassfish/pull/24713 That implies EE 10 Tyrus, right?
Yes, it does. We will update it in EE 10 Tyrus, too. Thanks @mnriem !
Hi Manfred, Tyrus 2.0.x (Jakarta EE 9) and Tyrus 2.1.x (Jakarta EE 10) do have module-info