search

eclipse-ee4j / wasp

WaSP, a Jakarta Pages implementation
Eclipse Public License 2.0
8 stars 9 forks source link

TLDSCanner is not loading system TLDs in Java 11.0.1 #2

Open bpcrao opened 5 years ago

bpcrao commented 5 years ago

The system tlds are skipped in few scenarios the only option is the class loader has to be URLClassLoader which is not the case is Java 11 and hence fails

https://stackoverflow.com/questions/55031222/java-11-tldscanner-not-loading-system-tlds

Thihup commented 3 years ago

Piranha uses a custom classloader, so it doesn't work with it either

arjantijms commented 3 years ago

I added the context attribute org.glassfish.wasp.useMultiJarScanAlgo which selects the more powerful scanner as of https://github.com/eclipse-ee4j/wasp/commit/566ac7dd0a65d819dc05e5ef3c9d522ec124304b. I tested this with JDK 15 and the latest Piranha, and there it works now.

@bpcrao can you test if this also works for you know, if you're still interested in this after all this time.

Next to the more powerful scanner we could also provide an additional SPI for the scanning.