PropertyNamingStrategy is not considered for JsonbCreators

[bmarwell]

Describe the bug

PropertyNamingStrategy is not considered for records

To Reproduce

• Create a record with camelCase fields
• Add a constructor (no parameters, no implementation) with @JsonbCreator.

• Create a propertyVisibilityStrategy:

  static class PrivateVisibilityStrategy implements PropertyVisibilityStrategy {
  
  @Override
  public boolean isVisible(Field field) {
    return true;
  }
  
  @Override
  public boolean isVisible(Method method) {
    return false;
  }
  }

• Use the naming Strategy with underscores
• Put it all together

      new JsonbConfig()
          .withAdapters(new AuthorIdAdapter())
          .withNullValues(Boolean.TRUE)
          .withFormatting(Boolean.TRUE)
          .withPropertyVisibilityStrategy(new PrivateVisibilityStrategy())
          .withPropertyNamingStrategy(PropertyNamingStrategy.LOWER_CASE_WITH_UNDERSCORES);

Try to read a JSON file and see this error:

jakarta.json.bind.JsonbException: JsonbCreator parameter firstName is missing in json document.

Expected behavior

SHould have used first_name instead.

System information:

• OS: Linux
• Java Version: 17 semeru
• Yasson Version: 2.0.4 and 3.0.2

Additional context

Example on this commit: https://github.com/bmarwell/jaxrs-test-showcase/pull/61/commits/71348e8d153300a4699ec33314bb577ec1c87228

[bmarwell]

Looking at ObjectDeserializer::deserialzeNext, it seems that getClassModel().getClassCustomization().getCreator() did not get the underscore property names.

This is being createad in MappingContext::createParseClassModelFunction which has the var ClassCustomization customization already containing no creator customization.

That in return is created by AnnotationIntrospector::getCreator. The method JsonbCreator createJsonbCreator checks for @JsonbProperty, but never considers the naming Strategy: https://github.com/eclipse-ee4j/yasson/blob/6e7ec79c54218a05342cbb65f5b150cc5892b7c2/src/main/java/org/eclipse/yasson/internal/AnnotationIntrospector.java#L208

In this line it should have considered the already known PropertyModel, just call model.get(parameter.getName()) to receive the JSON name.

[bmarwell]

Works in Apache Johnzon. When no @JsonbProperty is defined on a @JsonbCreator, the naming strategy is being considered.

[bmarwell]

Example project with builds of:

• johnzon
• johnzon-snapshot
• yasson2
• yasson3

... is here: https://github.com/bmarwell/jsonb-creator-property-naming

Romain fixed it in johnzen literally minutes after talking to him 😆 => https://github.com/apache/johnzon/commit/b25243b23f36f257e47d8fce9b914bb5c882889c

[Verdent]

Hi @bmarwell , I am finally having a little bit of time to take a look into this :-) Thank you for bringing this up and making fix for it as well.

[Verdent]

Fix merged