search

eclipse-ee4j / yasson

Eclipse Yasson project
https://projects.eclipse.org/projects/ee4j.yasson
Other
204 stars 96 forks source link

[#583] @JsonbCreator uses PropertyNamingStrategy. #584

Closed bmarwell closed 1 year ago

bmarwell commented 1 year ago

This might work, but I am not sure about what to pass in src/main/java16/org/eclipse/yasson/internal/ClassMultiReleaseExtension.java.

Verdent commented 1 year ago

Watch out for those copyright failures :-) It should be 2023 now.

bmarwell commented 1 year ago

Watch out for those copyright failures :-) It should be 2023 now.

Actually the plugin does not check commit date, but author date. As I amended the previous commit, it must be 2022 according to the plugin. Unexpected, but that is what it takes to make the plugin happy. :)

Verdent commented 1 year ago

Oh it seems you are having typo there :-)

bmarwell commented 1 year ago

Sorry, broken keyboard (spilled soda over it) 😆

jhanders34 commented 1 year ago

Any more progress on this PR?

Verdent commented 1 year ago

Oh, it seems it is failing on incorrectly separated imports. Otherwise, I think it is OK.

bmarwell commented 1 year ago

Oh, it seems it is failing on incorrectly separated imports. Otherwise, I think it is OK.

Sigh, sorry! I am too used to checking in IDE config 😞 will fix this ASAP.

Verdent commented 1 year ago

Perfect, thank you for this contribution @bmarwell