search

eclipse-efx / efxclipse-rt

Eclipse Public License 1.0
28 stars 29 forks source link

typo in createBasicThreadSyncronize #132

Open Bananeweizen opened 7 years ago

Bananeweizen commented 7 years ago

Just noticed in the announcement of the 3.0 version that there is a typo in the new API (missing h in sychronize): https://github.com/eclipse/efxclipse-rt/blob/master/bundles/runtime/org.eclipse.fx.core/src/org/eclipse/fx/core/ThreadSynchronize.java#L404.

(I did not create a PR since I don't have the repo locally, and github web edits don't pass Eclipse IP checks).

tomsontom commented 7 years ago

Grr that's unfortunate because this is public API now - I know eg in JFace we kept typos but because our API is used not that frequently I guess we can add a @Deprecate in 3.x and remove in 4.x