search

eclipse-efx / efxclipse-rt

Eclipse Public License 1.0
28 stars 29 forks source link

Resolved potential deadlock in FxClassLoader #433

Closed friedrichpit closed 3 years ago

friedrichpit commented 3 years ago

refs #429

tomsontom commented 3 years ago

looks good but it looks like you've not yet signed the ECA?!

friedrichpit commented 3 years ago

I have signed it. I appended the "Signed-off-by" footer in the latest commit. But apparently the check fails.

tomsontom commented 3 years ago

I think the problems are the first commits don't have the footer - so you'd have to squash the commits into one with the correct footer or if it is simpler create a new PR with just the correct commit ;-)

friedrichpit commented 3 years ago

First commits don't have the required footer. Closing. Drafting new pull request.

qtran commented 3 years ago

I have a question concerning this patch. FXClassloader is not only used in the Main Thread. We are speeding up the loading of FXML etc in a background task/thread pool. My concern is that this patch will cause memory leaks, see https://techblog.bozho.net/threadlocal-variables-and-thread-pools-it-can-go-wrong/