Closed friedrichpit closed 3 years ago
looks good but it looks like you've not yet signed the ECA?!
I have signed it. I appended the "Signed-off-by" footer in the latest commit. But apparently the check fails.
I think the problems are the first commits don't have the footer - so you'd have to squash the commits into one with the correct footer or if it is simpler create a new PR with just the correct commit ;-)
First commits don't have the required footer. Closing. Drafting new pull request.
I have a question concerning this patch. FXClassloader is not only used in the Main Thread. We are speeding up the loading of FXML etc in a background task/thread pool. My concern is that this patch will cause memory leaks, see https://techblog.bozho.net/threadlocal-variables-and-thread-pools-it-can-go-wrong/
refs #429
synchronized
frompostFindClass
reentrance
ist ThreadLocal