search

eclipse-egit / egit

EGit, the git integration of Eclipse IDE
https://www.eclipse.org/egit/
Eclipse Public License 2.0
13 stars 6 forks source link

Can't commit a message starting with GitHub identifier (#) #15

Closed basilevs closed 5 months ago

basilevs commented 5 months ago

Version

6.8.0

Operating System

MacOS

Eclipse version

2024-03

Bug description

Test steps

Change any file Add the file to Staged changes Enter commit message in Staging view:

#882 Style fixes

Hit commit button

Actual behavior

A modal dialog "No message" with a message: "You must enter a commit message"

Screenshot 2024-01-23 at 00 06 16

Expected behavior

Commit succeeds

Relevant log output

No response

Other information

While pretty-printing comment in commit message might be useful, use of popular issue reference format is much more important.

msohn commented 5 months ago

That's configurable using the option commit.cleanup. It you set it to whitespace lines starting with # aren't removed.

basilevs commented 5 months ago

Thanks