search

eclipse-egit / egit

EGit, the git integration of Eclipse IDE
https://www.eclipse.org/egit/
Eclipse Public License 2.0
13 stars 6 forks source link

Replace (partly unused) dependency to org.eclipse.osgi.services #8

Closed HannesWell closed 6 months ago

HannesWell commented 7 months ago

The bundle o.e.osgi.services is deprecated for removal as part of https://github.com/eclipse-equinox/equinox/issues/18 and already has been changed to be empty and only re-export the 'official' OSGi artifacts published to Maven-Central.

It should be replaced by imports of the desired org.osgi.service.* packages so that the runtime can choose a suitable provider independently of the bundle name.

Bananeweizen commented 7 months ago

Please recreate by following https://www.eclipse.org/lists/egit-dev/msg04848.html. I'll try to disable PRs via Otterdog for this repo. I guess that change is backwards compatible with older Eclipse versions, right?

HannesWell commented 7 months ago

Please recreate by following https://www.eclipse.org/lists/egit-dev/msg04848.html. I'll try to disable PRs via Otterdog for this repo.

Thanks for the hint. But I have to admit that while I really like the workflow and power of Gerrit, I'm reluctant to share my Github credentials with a third-party service. Nevertheless I will look into this in the future, if you want to create a change from this in the meantime I would also be happy about it. :)

I guess that change is backwards compatible with older Eclipse versions, right?

Yes, this will work on all Eclipse versions that have a bundle installed that export org.osgi.service.event in version 1.4 (which was released 2018) or later. If you are sure 1.3 is also sufficient I can widen the range as well.

Bananeweizen commented 6 months ago

Imported as https://eclipse.gerrithub.io/c/eclipse-egit/egit/+/1173902. @HannesWell You are not sharing your credentials with a third party. You log in via Github login, as you would for all kinds of GitHub connected services, so that GitHub does OAuth (or whatever it is) for you. The third party only gets the exact data you see during the (GitHub based) confirmation to share data X, Y and Z.

HannesWell commented 6 months ago

Thank you Michael. Until now (AFAICT) I have never used any GH related services and never used my credentials to login through GitHub anywhere else than GH. But I'll give it a try.