search

eclipse-embed-cdt / eclipse-plugins

The Eclipse Embedded CDT plug-ins for Arm & RISC-V C/C++ developers (formerly known as the GNU MCU Eclipse plug-ins). Includes the archive of previous plug-ins versions, as Releases.
http://eclipse-embed-cdt.github.io/
Eclipse Public License 2.0
555 stars 129 forks source link

#391 Releng: clean up the respository manifests #392

Closed ruspl-afed closed 4 years ago

ruspl-afed commented 4 years ago

Remove duplicated group and version for artifact in pom.xml Remove unused url and version attributes for feature in category.xml

Signed-off-by: Alexander Fedorov alexander.fedorov@arsysop.ru

ruspl-afed commented 4 years ago

@ilg-ul the travis was not triggered for the PR, is it intentional?

ruspl-afed commented 4 years ago

Ah, in fact it was, but this is not a part of "checks". I would consider to employ GiHub Actions as they are more powerful and better integrated. @ilg-ul WDYT?

ilg-ul commented 4 years ago

the travis was not triggered for the PR

No, unfortunately this is just another joy of migrating the project to the foundation organisation, permanent friction with the admins :-(

I asked for rights to enable Travis a few days ago, but so far received no reply.

ilg-ul commented 4 years ago

GiHub Actions

Yes, I played a bit with it, I guess it is ok, but every such small change requires time to implement and test, and I don't know what to do first...

For now I would stick with what is functional, and address changes one my one, time permitting.

ilg-ul commented 4 years ago

You based your changes on develop, which is a bit behind master. Would it be ok to merge it?

ruspl-afed commented 4 years ago

You based your changes on develop, which is a bit behind master

submit the pull request to the develop branch

this is what I can read in https://github.com/eclipse-embed-cdt/eclipse-plugins/blob/develop/CONTRIBUTING.md

ilg-ul commented 4 years ago

this is what I can read in

:-(

Yes, just that I started work on the new release, which is built from master, and I forgot to update develop.

How can we fix this? If I merge this, should I next merge master into develop?

ruspl-afed commented 4 years ago

I changed base to master , but probably you can publish/update the policy? Currently the develop is default branch and it is not clear that master should be preferred.

ilg-ul commented 4 years ago

develop is preferred, just that now I was a bit sloppy in maintaining the repo consistent with the policy.