search

eclipse-embed-cdt / eclipse-plugins

The Eclipse Embedded CDT plug-ins for Arm & RISC-V C/C++ developers (formerly known as the GNU MCU Eclipse plug-ins). Includes the archive of previous plug-ins versions, as Releases.
http://eclipse-embed-cdt.github.io/
Eclipse Public License 2.0
555 stars 129 forks source link

Generate "source" features that constains "source" bundles #397

Closed ruspl-afed closed 3 years ago

ruspl-afed commented 3 years ago

Our p2 repository should contain sources for all the bundles. I think this is one of requirements to join SimRel but I cannot find it to reference here. At least that's what all good Eclipse citizens do.

ilg-ul commented 3 years ago

Agreed.

ilg-ul commented 3 years ago

Fixed in 2020-08-01 by Alexander.

ilg-ul commented 3 years ago

Alexander, what is the purpose of the source packages? Only to provide the source files for the Java classes when debugging?

Because I checked some source .jar files, and they only include the ilg.gnumcueclipse.* folders, and some minimal metadata.

All other files were skipped. When I check in Eclipse the build.properties file, the Binary Build lists has most files selected, but the Source Build section has no files selected at all. Is this ok?

ruspl-afed commented 3 years ago

Alexander, what is the purpose of the source packages

I think the primary reason is compliance with EPL-2.0, but also other benefits like source navigation that you already mentioned.

  1. REQUIREMENTS

3.1 If a Contributor Distributes the Program in any form, then:

a) the Program must also be made available as Source Code

As for the content of the source build I plan to revisit all the bundles as a part of #402

ilg-ul commented 3 years ago

Ok, great.