Closed flit closed 3 years ago
Hi Chris,
Thank you for the PR, I guess it is ok.
However, I see that the CI complains about an outdated ECA.
Jonah @jonahgraham, what should we do in order to merge this PR?
Whoops, just tell me what I need to do.
Thanks @flit for the improvements. The project is part of the Eclipse Foundation and we need you to sign the ECA and sign off your git commits.
To sign ECA visit https://accounts.eclipse.org/user/eca and complete the online form.
Thanks, and please let me know if you have any further questions.
Done!
I could not find any way to rerun the CI job.
Unless Jonah knows a trick, you'll probably have to push something to trigger a new check.
I don't know why, but neither of the email addresses (flit@me or chris..(at)nxp) in these commits are passing the ECA check. Also, I note on your profile a third address (chris...(at)arm).
Which one did you sign the ECA with? The commits need to be authored by that email address. I recommend all the commits be by the same author email address - I don't know how/if to handle multiple email addresses from the same user.
Also, the commits need to be signed off. Run git commit --amend --sign-off.
See https://wiki.eclipse.org/Development_Resources/Contributing_via_Git#Eclipse_Contributor_Agreement and https://wiki.eclipse.org/Development_Resources/Contributing_via_Git#Signing_off_on_a_commit for more info.
Thanks. Jonah
Normally I use only flit@me for personal contributions and (try to) use chris@arm for work contributions. But since some of these changes are originally from quite a while ago, there's the commit with chris@nxp from before I moved to Arm. I'll have to recreate that commit since I obviously can't create an account to sign the ECA. Anyway, I've signed the ECA with all my email addresses just to be fully covered; sadly there's no way to associate multiple email addresses with an Eclipse account so it's kind of a pain to manage.
Thanks for the tip about signing off the commits.
It seems ok now. If Jonah also agrees, we can merge these commits.
Thanks @flit for jumping through the hoops. Next time it will be easier. The ECA checker had approved this pr, so @ilg-ul it is good to go!
No worries! I appreciate your guidance here. 😄
Done.
Thank you, Chris.
Thank you!
The new release candidate, which includes the new pyocd plug-ins, is available for testing from:
This pull request combines updates, bug fixes, and general improvements for the pyOCD launch config plugin.
Major changes:
pyocd
combined tool (instead of deprecatedpyocd-gdbserver
tool).DataRequestMonitor<?>
. While waiting for a call to pyocd to finish, a message is shown in the launch config window.--elf
argument.(There is still a lot of room for improvement after this PR, mostly in supporting all the features pyocd has gained in the last 4-5 years since the plugin was first written.)
Fixes #349