eclipse-embed-cdt / eclipse-plugins

The Eclipse Embedded CDT plug-ins for Arm & RISC-V C/C++ developers (formerly known as the GNU MCU Eclipse plug-ins). Includes the archive of previous plug-ins versions, as Releases.
http://eclipse-embed-cdt.github.io/
Eclipse Public License 2.0
558 stars 130 forks source link

pyocd additional settings #471

Closed flit closed 3 years ago

flit commented 3 years ago

This PR updates the pyocd launch config to support modern features of pyocd.

Some settings from the startup tab that don't make sense for pyocd are removed:

Plus some improvements:

Note: this PR includes the change in #470. I was planning to rebase this PR after the other is merged, but if you prefer we can close #470 and just use this one.

ilg-ul commented 3 years ago

I don't know what would be the best strategy for merging your code, personally I would accept it, but the Eclipse Foundation procedures, which are a bit more strict, might require a review.

Jonah, please advice.

flit commented 3 years ago

No problem, let's just see what Jonah says and I'll be happy to do anything required.

jonahgraham commented 3 years ago

This falls under the 1000 LOC for non-committers limit, and has passed ECA checks, so looks good to me.

BTW I did this to check size of contribution:

$ git diff HEAD origin/develop --shortstat 
 10 files changed, 265 insertions(+), 386 deletions(-)

where HEAD is the head commit of this change.

ilg-ul commented 3 years ago

Chris, please rebase your PR and as soon as it passes the CI checks it'll be merged.

ilg-ul commented 3 years ago

And, Chris, I would also appreciate an estimate when the pyocd plug-ins will be ready for the next release, since we also have to do some maintenance and it would be better to have the repo stable and frozen.

flit commented 3 years ago

Ready to go.

You can consider the pyocd plugins frozen for this release. Now I'm back from holiday, I need to focus on my research projects for a while anyway.

ilg-ul commented 3 years ago

Thank you!

flit commented 3 years ago

Thank you! 😄