Bundle symbolic name of branding plug-in is wrong

eclipse-embed-cdt / eclipse-plugins

The Eclipse Embedded CDT plug-ins for Arm & RISC-V C/C++ developers (formerly known as the GNU MCU Eclipse plug-ins). Includes the archive of previous plug-ins versions, as Releases.

http://eclipse-embed-cdt.github.io/

Eclipse Public License 2.0

554 stars 130 forks source link

Bundle symbolic name of branding plug-in is wrong #480

Closed jonahgraham closed 3 years ago

jonahgraham commented 3 years ago

The Bundle-SymbolicName of org.eclipse.embedcdt-branding is missing the -branding suffix.

https://github.com/eclipse-embed-cdt/eclipse-plugins/blob/37d2e4f1bf89f1d7ab57511bb6ca102f718b85d9/branding/org.eclipse.embedcdt-branding/META-INF/MANIFEST.MF#L4

This causes lots of "confusion" in Eclipse p2. It currently prevents upgrading from 6.0.0 -> 6.1.0.

jonahgraham commented 3 years ago

Hmm - I may reopen. The above doesn't match what I expected, but it isn't actually wrong or duplicated.