eclipse-embed-cdt / eclipse-plugins

The Eclipse Embedded CDT plug-ins for Arm & RISC-V C/C++ developers (formerly known as the GNU MCU Eclipse plug-ins). Includes the archive of previous plug-ins versions, as Releases.
http://eclipse-embed-cdt.github.io/
Eclipse Public License 2.0
554 stars 130 forks source link

Add some visual separation between toolchain settings #575

Closed jonahgraham closed 1 year ago

jonahgraham commented 1 year ago

The change in XpackDirectoryNotStrictFieldEditor fixes the implementation to allow doFillIntoGrid to be called multiple times. This is how the other field editors handle it. This is needed now because of how the layout is now being handled with the extra layer of UI hierarchy.

TODO:

Fixes #574

ilg-ul commented 1 year ago

I checked the new look on macOS and it also looks nice. :-)

However something happened in the logic behind the xPack button, since it remains always disabled.

It should be enabled for toolchains installed via xpm, and show the available versions.

jonahgraham commented 1 year ago

However something happened in the logic behind the xPack button, since it remains always disabled.

Oops :-( I have now fixed that and tested it across all the pages that use xpack button. I will push the fix with that in a little while.

jonahgraham commented 1 year ago

@ilg-ul - I am done on this PR. I am happy to fix any bugs and update wording, but unless you feel it is critical I don't think I will do any other refactoring on this.

ilg-ul commented 1 year ago

Merged. Great work, thank you!