search

eclipse-emf / org.eclipse.emf

Eclipse Public License 2.0
10 stars 13 forks source link

Support option XMLResource.OPTION_RESOLVE_ENTITIES #11

Closed merks closed 1 year ago

merks commented 1 year ago

This option is false by default and will prevent XMLHandler.resolveEntity(String, String) from loading external entities.

https://github.com/eclipse-emf/org.eclipse.emf/issues/10

merks commented 1 year ago

@jukzi

I did the changes via a PR instead of a direct commit. Does this look okay?

jukzi commented 1 year ago

It would be good if the commit message contains a documentation how the caller/user can enable old behavior.

merks commented 1 year ago

It would be good if the commit message contains a documentation how the caller/user can enable old behavior.

Any developer using EMF will generally understand how to use load options. The user can do nothing...

merks commented 1 year ago

@jukzi

I think this is done.

I will probably want to produce a milestone build and contribute it to the platform and for m2...

jukzi commented 1 year ago

I tested the change and confirm eclipse Editor is much faster with this change for files that refer to external entities.

jukzi commented 1 year ago

Thanks, Ed