search

eclipse-emf / org.eclipse.emf

Eclipse Public License 2.0
10 stars 13 forks source link

Remove re-export of org.apache.log4j bundle from emf.ecore.xcore #15

Closed HannesWell closed 10 months ago

HannesWell commented 10 months ago

Requiring the bundle org.apache.log4j forces the actual org.apache.log4j bundle in applications that contain emf.ecore.xcore and makes it impossible to bridge/redirect to other logging back-ends.

In general this has the potential to break existing plugins that require emf.ecore.xcore and don't import or require log4j by themself. @merks can you assess if there are relevant cases for that or if that is only hypothetical? In Xtext there was a little 'poll' how important backwards compatibility in this area: https://github.com/eclipse/xtext/issues/2668

merks commented 10 months ago

Looking in the history, it's always been this way since the initial code contribution. Perhaps it was generated that way originally. It seems like a good to get rid of it. I doubt there is anything downstream that would be broken and needs such binary compatibility so I'm find with making an executive decision....

HannesWell commented 10 months ago

Thanks Ed!