search

eclipse-emf / org.eclipse.emf

Eclipse Public License 2.0
10 stars 13 forks source link

Remove org.apache.log4j from emf.ecore.xcore features #16

Closed HannesWell closed 10 months ago

HannesWell commented 10 months ago

Follow-up on https://github.com/eclipse-emf/org.eclipse.emf/pull/15.

Importing the bundle org.apache.log4j forces the actual org.apache.log4j bundle in applications that maybe use a bridge/redirection to another logging back-end and thus don't use the org.apache.log4j bundle to provide the log4j-1 API. If necessary org.apache.log4j is pulled in as transitive dependency anyways.

Additionally this removes the mavenMappings for log4j-1 from the EMF.aggr or is this still relevant?

HannesWell commented 10 months ago

The inclusion of org.apache.commons.logging is now removed too.

merks commented 10 months ago

Things do get published to Maven central:

https://repo1.maven.org/maven2/org/eclipse/emf/org.eclipse.emf.ecore.xcore/1.26.0/org.eclipse.emf.ecore.xcore-1.26.0.pom

I have no idea if anyone consumes it from there. Probably Xtext's Xcore builder stuff. I don't have any package mappings so that dependency will just disappear....

HannesWell commented 10 months ago

Things do get published to Maven central:

https://repo1.maven.org/maven2/org/eclipse/emf/org.eclipse.emf.ecore.xcore/1.26.0/org.eclipse.emf.ecore.xcore-1.26.0.pom

I have no idea if anyone consumes it from there. Probably Xtext's Xcore builder stuff. I don't have any package mappings so that dependency will just disappear....

Isn't Tycho now capable to to generate the dependencies properly? I don't now that for sure. If possible and you tell me how to do it I can add mappings for packages.

HannesWell commented 10 months ago

If you agree on https://github.com/eclipse-emf/org.eclipse.emf/pull/17, then the dependencies have to be changed from log4j-1 to slf4j-api. The dependency to org.apache.commons.logging seemed to be unnecessary.