eclipse-emfcloud / ecore-glsp

ecore-glsp
Other
32 stars 25 forks source link

Undo does not work for changes in the property view #106

Closed JonasHelming closed 3 years ago

JonasHelming commented 3 years ago

Make a class abstract via the property view and undo => no effect

CamilleLetavernier commented 3 years ago

Undo/Redo is fixed with #109. However, depending on the keyboard layout and the Theia settings, the key-binding for undo may change. To make sure that Undo is properly mapped to "Ctrl + Z", regardless of your keyboard layout, you need to change the "Keyboard: Dispatch" setting to "Keycode" (The default is "Code").

Without this, German keyboards would need to press Ctrl + Y for Undo, and French keyboards would need Ctrl + W (But that would close the browser tab rather than undoing the change :) )

Also see the corresponding GLSP discussion: https://github.com/eclipse-glsp/glsp/discussions/428