search

eclipse-emfcloud / ecore-glsp

ecore-glsp
Other
32 stars 25 forks source link

#39 Migrate the Ecore GLSP Server build to P2 #40

Closed CamilleLetavernier closed 4 years ago

CamilleLetavernier commented 4 years ago

fixes #39

CamilleLetavernier commented 4 years ago

The plug-in approach doesn't work with Maven Shade; I'll need to find a different approach. It's currently used to package the Ecore GLSP Server in an all-in-one jar, that can then be started directly from the Client Backend (So it's used to avoid having to start the server manually).

When developing from Eclipse, it's not an issue, as we resolve all dependencies through PDE, but for a deployed runtime, we need a different solution. We might provide an Eclipse product (Like we already do for the Ecore Model backend), or maybe we can make Maven Shade work with plug-ins.

@tortmayr @planger @simongraband What do you think?

CamilleLetavernier commented 4 years ago

In the meantime, I'll split the PR in two: one for updating GLSP with the current build (Plain Maven), and one follow-up for the migration to P2

tortmayr commented 4 years ago

We currently use maven-shade only in plain maven builds. If you have a p2 build the recommended solution is to provide a headless eclipse product. As you mentioned, you already do this for the ecore model backend, so adapting the approach for the glsp server should not be an issue.

CamilleLetavernier commented 4 years ago

If you have a p2 build the recommended solution is to provide a headless eclipse product

:+1:

CamilleLetavernier commented 4 years ago

I've updated the PR:

The new PR: