eclipse-emfcloud / emfcloud-modelserver

Modelserver component
Other
40 stars 21 forks source link

API V2: Open the SettingValue API (Currently final) #180

Closed CamilleLetavernier closed 2 years ago

CamilleLetavernier commented 2 years ago

The SettingValue class is used to describe the EMF Value to edit for a command, and is derived from the Json Path. It is currently a final class, and can't be extended. For regular EMF Models, extension is not necessary.

However, we introducing custom EMF-to-Json Codecs, it may also be necessary to introduce equivalent JsonPointer-to-SettingValue transformation, in the JsonPatchHelper. In some cases, the path may contain segments that only exist in the json model, and may not be mapped to an EMF EStructuralFeature. In such cases, it is necessary to extend the SettingValue, so it can be used for such customizations.

Therefore, it would be really useful to open the SettingValue API, by making it non-final.