search

eclipse-emfcloud / emfcloud-modelserver

Modelserver component
Other
43 stars 21 forks source link

193: JsonPatchHelper should normalize URIs when using EMF-style paths #194

Closed CamilleLetavernier closed 2 years ago

CamilleLetavernier commented 2 years ago

Contributed on behalf of STMicroelectronics.

fixes #193

CamilleLetavernier commented 2 years ago

I've reverted the changes to DefaultModelResourceManager, because it seems that all URIs should be normalized before they get passed to this class. Adding the ModelURIConverter to the DefaultModleResourceManager seemed to add unnecessary complexity (Especially for test setup), and was mostly redundant.

cdamus commented 2 years ago

I've reverted the changes to DefaultModelResourceManager, because it seems that all URIs should be normalized before they get passed to this class. Adding the ModelURIConverter to the DefaultModleResourceManager seemed to add unnecessary complexity (Especially for test setup), and was mostly redundant.

I think I reviewed this after you made that change? Because I didn't notice it and I would have commented that yes, it was unnecessary. 😉